Skip to content

Add test for entailment of literal type #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

niklasl
Copy link
Contributor

@niklasl niklasl commented Jun 28, 2025

Adds test for second semantic condition of RDF Interpretations (based on example pattern).

@niklasl niklasl requested review from gkellogg and pfps June 28, 2025 07:36
@pfps
Copy link
Contributor

pfps commented Jul 3, 2025

Should this be in the RDF 1.1 tests?

@niklasl
Copy link
Contributor Author

niklasl commented Jul 3, 2025

Should this be in the RDF 1.1 tests?

Good point; I believe they should. There is currently no rdf11/rdf-semantics directory; but I can set that up in this PR. Are there other tests that should be moved there? (Presumably in a separate PR.)

@pfps
Copy link
Contributor

pfps commented Jul 3, 2025

The float and double tests, at least.

@gkellogg
Copy link
Member

gkellogg commented Jul 3, 2025

Should this be in the RDF 1.1 tests?

Good point; I believe they should. There is currently no rdf11/rdf-semantics directory; but I can set that up in this PR. Are there other tests that should be moved there? (Presumably in a separate PR.)

In 1.1, it was rdf-mt, so rdf/rdf11/rdf-mt contains all the 1.1 semantics tests.

@niklasl
Copy link
Contributor Author

niklasl commented Jul 3, 2025

Should this be in the RDF 1.1 tests?

Good point; I believe they should. There is currently no rdf11/rdf-semantics directory; but I can set that up in this PR. Are there other tests that should be moved there? (Presumably in a separate PR.)

In 1.1, it was rdf-mt, so rdf/rdf11/rdf-mt contains all the 1.1 semantics tests.

Ah, of course; thanks! I'll move this there (unless I've missed such a case there...).

@niklasl
Copy link
Contributor Author

niklasl commented Jul 4, 2025

There are two manifests in rdf/rdf11/rdf-mt/. The README says:

The manifest.ttl file in this directory lists all of the approved tests in the
RDF WG's RDF Entailment test suite. The manifest-az.ttl file in this
directory lists proposed tests. Please try both sets of tests as
appropriate, as some of the proposed tests may become approved tests.

What does "approved" and "proposed" mean here? Where do I put this test?

@gkellogg
Copy link
Member

gkellogg commented Jul 4, 2025

It would be good to get to just a single manifest, and integrate any -az tests that are appropriate.

in the past, working groups marked approved vs proposed tests. My view now, is that the PR process satisfies this, and any tests added via a PR are effectively approved.

@afs
Copy link
Contributor

afs commented Jul 13, 2025

It would be good to get to just a single manifest, and integrate any -az tests that are appropriate.

Agreed - incorporate and rename. They are the product of the working group so take out and "-az" and become a name reflecting the test like the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants